Include extension types in 'implementers' list #3658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kallentu
approved these changes
Feb 16, 2024
| .findCanonicalFor( | ||
| packageGraph.implementors[implementor] ?? const []) | ||
| .forEach(addToResult); | ||
| var implementors = packageGraph.implementors[implementor]; |
There was a problem hiding this comment.
Could we name this something slightly different from line 545 (or the opposite)? My eyes are glazing over see them because they're so similar haha.
There was a problem hiding this comment.
And also keep implementor vs implementer spelling consistent.
There was a problem hiding this comment.
I've renamed the lower one immediateImplementors.
It looks like everything in this file is implementor; the display name in the HTML is "implementer", which I think is more correct. But to change everything in this file would make the diff even bigger. I'd like to address that in a follow-up.
test/templates/class_test.dart
Outdated
| return resourceProvider.readLines([packagePath, 'doc', ...filePath]); | ||
| } | ||
|
|
||
| void test_pageListsClassesThatExtend() async { |
There was a problem hiding this comment.
For all the tests, maybe group them like test_class_extends test_class_implements test_mixin_constraintsSuperclass?
test/templates/class_test.dart
Outdated
| ]); | ||
| } | ||
|
|
||
| @FailingTest(reason: 'Not implemented yet; should be?') |
There was a problem hiding this comment.
This isn't? That's surprising haha.
There was a problem hiding this comment.
Yeah I wrote the test because I assumed it worked. :/
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Feb 21, 2024
…, sse, stream_channel, tools, vector_math, web, webdev, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. async (https://github.com/dart-lang/async/compare/24266ca..6cdbc41): 6cdbc41 2024-02-15 Kevin Moore Update to latest lints, require Dart 3.2 (dart-archive/async#267) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/74a0efe..7956230): 7956230 2024-02-16 sigmundch Add extra flags to disable throttling behavior. (dart-archive/browser_launcher#55) dartdoc (https://github.com/dart-lang/dartdoc/compare/7e171fc..7a9df65): 7a9df65f 2024-02-20 Parker Lougheed Add fallback text for sidebar failing to load (dart-lang/dartdoc#3643) 9bcabb50 2024-02-20 Parker Lougheed Fix missing left sidebar on extension type pages (dart-lang/dartdoc#3662) e8b8faa2 2024-02-16 Sam Rawlins Include extension types in 'implementers' list (dart-lang/dartdoc#3658) http (https://github.com/dart-lang/http/compare/6d9f9ef..ce0de37): ce0de37 2024-02-21 Derek Xu Populate package:http_profile (dart-lang/http#1046) 75e01f4 2024-02-20 Brian Quinlan Create a simple WebSocket interface (dart-lang/http#1128) markdown (https://github.com/dart-lang/markdown/compare/c2b8429..d735b0b): d735b0b 2024-02-21 Tom Yeh Fix `#578`: list with checkbox mixed with empty lines (dart-lang/markdown#583) 6efe141 2024-02-14 Kevin Moore Migrate example to pkg:web, update minimum required Dart version (dart-lang/markdown#582) protobuf (https://github.com/dart-lang/protobuf/compare/a293fb9..f085bfd): f085bfd 2024-02-20 Ömer Sinan Ağacan Fix message_set.dart copyright year (google/protobuf.dart#912) sse (https://github.com/dart-lang/sse/compare/af7d8d0..13ec752): 13ec752 2024-02-20 Kevin Moore blast_repo fixes (dart-lang/sse#104) 2830dc9 2024-02-16 Kevin Moore Support the latest pkg:web, require Dart 3.3 (dart-lang/sse#103) stream_channel (https://github.com/dart-lang/stream_channel/compare/851336f..e02a5dd): e02a5dd 2024-02-16 Kevin Moore Require Dart 3.3, update and fix lints (dart-lang/stream_channel#100) e62706e 2024-02-16 Kevin Moore blast_repo fixes (dart-lang/stream_channel#101) tools (https://github.com/dart-lang/tools/compare/2ef7673..9f4e6a4): 9f4e6a4 2024-02-16 Elias Yishak Helper to resolve dart version for clients of analytics (dart-lang/tools#233) 8323b21 2024-02-13 Elias Yishak New event added for sending analytics within package on errors (dart-lang/tools#229) vector_math (https://github.com/google/vector_math.dart/compare/cb976c7..3706feb): 3706feb 2024-02-18 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (google/vector_math.dart#313) web (https://github.com/dart-lang/web/compare/a54a1f0..975e55c): 975e55c 2024-02-15 Kevin Moore Add TrustedTypes (dart-lang/web#173) 0447807 2024-02-15 Srujan Gaddam Add info on generation conventions (dart-lang/web#171) webdev (https://github.com/dart-lang/webdev/compare/629c632..51b5484): 51b54843 2024-02-14 Elliott Brooks Implement `setFlag` for 'pause_isolates_on_start' (dart-lang/webdev#2373) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/2a9a11b..82ab64d): 82ab64d 2024-02-21 Danny Tuppeny Fix line endings for inserted maps on Windows (dart-lang/yaml_edit#66) 6906ac4 2024-02-20 Devon Carew update the publish workflow (dart-lang/yaml_edit#67) Change-Id: I246c393586e3d6239925ac3cf3a6a245d86a2bf5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353581 Reviewed-by: Kevin Moore <kevmoo@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3656
I'll get to the punchline quickly: The gist of this fix is a single line in
package_graph.dart:_addToImplementers(library.extensionTypes);. The rest is mostly test infra, tech debt cleanup, and yak-shaving:implementerssection, so I addedclass_test.dartto introduce such tests.addImplementer(), which must now also consider extension types, did so manyas InheritingContainercalls that I decided to add some helpers to do all of this casting as part of this or that class's responsibility, instead of the responsibility ofaddImplementor(). SomixedInTypesnow has siblingmixedInElements, andpublicInterfaceshaspublicInterfaceElements, etc. I found most of the callers concerned themselves with the elements, so I changed most callers to usemixedInElements. Same withimplementorsetc.mixedInTypes@visibleForTestingsince it is almost entirely replaced bymixedInElements. But it was still used intemplates.runtime_renderers.dartuntil I corrected the codegen to account for a PropertyAccessorElement'svariable.Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.